Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FactoryGameSteam and FactoryGameEGS install types #223

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

budak7273
Copy link
Member

No description provided.

@mircearoata
Copy link
Member

The game running check also needs updating https://github.com/satisfactorymodding/SatisfactoryModManager/blob/master/backend/ficsitcli/wrapper.go#L59

We should also replace references to Early Access with Release in variable names, and maybe a blank string for the displayed value https://github.com/satisfactorymodding/SatisfactoryModManager/blob/master/backend/installfinders/common/types.go#L6 (can be another PR later though)

backend/ficsitcli/wrapper.go Outdated Show resolved Hide resolved
@budak7273 budak7273 merged commit 35e7fc2 into master Sep 12, 2024
16 checks passed
@budak7273 budak7273 deleted the add-1.0-install-types branch September 12, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants