Always stop progress updates after install finishes

satisfactorymodding · Dec 29, 2023 · 4a8484b · 4a8484b
1 parent 83e67a4
commit 4a8484b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/backend/bindings/ficsitcli/process.go b/backend/bindings/ficsitcli/process.go
@@ -30,6 +30,9 @@ func (f *FicsitCLI) validateInstall(installation *InstallationInfo, progressItem
 
 	progressTicker := time.NewTicker(100 * time.Millisecond)
 	done := make(chan bool)
+	defer progressTicker.Stop()
+	defer close(done)
+
 	go func() {
 		for {
 			select {
@@ -106,8 +109,6 @@ func (f *FicsitCLI) validateInstall(installation *InstallationInfo, progressItem
 				return oldValue, false
 			})
 		}
-		progressTicker.Stop()
-		close(done)
 	}()
 
 	installErr := installation.Installation.Install(f.ficsitCli, installChannel)