Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if layer is absent from assay #189

Merged
merged 3 commits into from
May 3, 2024

Conversation

maxim-h
Copy link
Contributor

@maxim-h maxim-h commented Mar 20, 2024

This is meant to help diagnose issues when assay doesn't have desired layer. For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659, specifically the suggestion from Sam.

The warning message might not be the prettiest, but I didn't want to go through Layer.Seurat method to get the assay name.

This is meant to help diagnose issues when assay doesn't have desired layer. 
For example see satijalab/seurat#8658 and discussion in satijalab/seurat#8659.

The warning message might not be the prettiest, but I didn't want to go through `Layer.Seurat` method to get the assay name.
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maxim-h, sorry for the delay. This looks good, thanks for the addition!

Bump develop version
@mojaveazure mojaveazure merged commit ceafa1e into satijalab:develop May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants