Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalise the registration link in navbar solution from @jdblischack to work across all ticket providers #47

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DaveParr
Copy link
Member

@DaveParr DaveParr commented Oct 7, 2021

in #45 @jdblischak proposed a solution to generalise based on modifying the section ID.

Another idea: change the template files for the registration providers so that they all use id="registration". Then the navbar link could be shared between them, i.e. href="{{ .Site.BaseURL }}#registration">. I think in the edge case of the template where multiple registration vendors are enabled, the link would take you to the first div with a matching id.

I've implemented this along with an OR statement in the nav bar to tirgger the link being available or not.

@DaveParr DaveParr added the hacktoberfest-accepted for hacktoberfest label Oct 7, 2021
@DaveParr DaveParr requested a review from jdblischak October 7, 2021 13:40
@DaveParr DaveParr self-assigned this Oct 7, 2021
@DaveParr
Copy link
Member Author

DaveParr commented Oct 7, 2021

Just realised I've made an error in the nav.html. Reworking now.

Copy link
Member

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't explicitly test it out, but this does implement my suggestion, so I approve! Thanks @DaveParr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants