-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upload/download for sas content #550
Conversation
4e17c65
to
242da85
Compare
b5c867c
to
0e50c8d
Compare
10ab837
to
d3f0951
Compare
It failed to download files with Windows OS. |
Local files are not shown on file selection window if trying to Upload one with Windows OS. |
'Uploading files...' keeps showing in some scenarios.
|
This has been resolved in 41016de. You should now see an error message and the NOTE: The messaging is not ideal for a file > 20M (it just says something generic about an upload failure). That said, this is also the case w/ dragging + dropping a file. For now, I think this is probably sufficient but at some future point we may want to investigate making our failure messages a little more granular. |
I'm currently waiting on a windows VM to be able to test/debug these. |
These should both be resolved now (by 22dadbd and 6c39b07). The behavior of uploads has been tweaked a bit. On Mac, a user can use the On Windows & Linux, a user will be presented with two options: |
@Zhirong2022 This is ready to test again when you have a moment |
@scottdover Thank you so much for your investigation and help. I verified the issues in Windows OS, it can upload files and folders through Upload file(s) and Upload folder(s) on the context menu. For the error prompt, it can be enhanced. I have no other concerns. |
6c39b07
to
0d90c24
Compare
Summary
This makes a few changes around uploading/downloading files in the sas extension:
Upload
context menu item to SAS content: This feature allows a user to upload one or more files to sas contentDownload
context menu item to SAS content: This allows you to download one or more files or folders, and specify where to save themDownload
context menu item to the results pane. Clicking this will allow the user to save the results as an html fileResultsPanelSubscriptionProvider
which is responsible for handling commands against the results panelTesting