Skip to content

Commit

Permalink
build: remove release target from Makefile
Browse files Browse the repository at this point in the history
We use the goreleaser github action rather than the make target.
  • Loading branch information
wfscheper committed Jul 14, 2022
1 parent 381c1e9 commit 8440ca9
Show file tree
Hide file tree
Showing 3 changed files with 606 additions and 432 deletions.
16 changes: 1 addition & 15 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ GOBUILD = $(GO) build
GOCOV = $(TOOLBIN)/gocov
GOCOVXML = $(TOOLBIN)/gocov-xml
GOINSTALL := GOOS= GOARCH= $(GO) install
GORELEASER = $(TOOLBIN)/goreleaser
LINTER = $(TOOLBIN)/golangci-lint
STENTOR = $(TOOLBIN)/stentor
TESTER = $(TOOLBIN)/gotestsum
Expand Down Expand Up @@ -35,13 +34,9 @@ TESTFORMAT = short
TIMEOUT = 60s

# conditional flags
ifeq ($(RELEASE_DRY_RUN),false)
TAGFLAGS = -release -push
RELEASEFLAGS =
ifeq ($(DRY_RUN),false)
STENTORFLAGS = -release
else
TAGFLAGS =
RELEASEFLAGS = --snapshot --skip-publish --rm-dist
STENTORFLAGS =
endif

Expand Down Expand Up @@ -78,14 +73,6 @@ format: lint
lint: | $(LINTER)
$(LINTER) run $(LINTFLAGS)

.PHONY: release
release: build | $(GORELEASER)
$(TARGET) $(TAGFLAGS)
BUILDDATE=$(BUILDDATE) \
COMMIT=$(COMMIT) \
VERSION=$(VERSION) \
$(GORELEASER) $(RELEASEFLAGS)

.PHONY: report
report: TESTFLAGS := $(REPORTFLAGS) $(TESTFLAGS)
report: test | $(GOCOV) $(GOCOVXML)
Expand Down Expand Up @@ -114,7 +101,6 @@ endef
# tool targets
$(eval $(call installtool,$(GOCOV),github.com/axw/gocov/gocov))
$(eval $(call installtool,$(GOCOVXML),github.com/AlekSi/gocov-xml))
$(eval $(call installtool,$(GORELEASER),github.com/goreleaser/goreleaser))
$(eval $(call installtool,$(LINTER),github.com/golangci/golangci-lint/cmd/golangci-lint))
$(eval $(call installtool,$(STENTOR),github.com/wfscheper/stentor/cmd/stentor))
$(eval $(call installtool,$(TESTER),gotest.tools/gotestsum))
Expand Down
Loading

0 comments on commit 8440ca9

Please sign in to comment.