Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in color.is-missing() + "Breaking Changes" section #1285

Merged
merged 5 commits into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/documentation/breaking-changes/color-4-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ warning when constructing a new [legacy color] or calling `color.change()` for a
legacy color. In either case, if you pass a `space` parameter explicitly, you'll
opt into the new behavior and `null` will be treated as a missing channel.

[legacy color]: /documentation/values/colors#legacy-color-spaces

## Transition Period

{% compatibility 'dart: "1.79.0"', 'libsass: false', 'ruby: false' %}{% endcompatibility %}
Expand Down
4 changes: 2 additions & 2 deletions source/documentation/breaking-changes/function-units.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ will forbid any units.

{% compatibility 'dart: "1.56.0"', 'libsass: false', 'ruby: false' %}{% endcompatibility %}

Currently, Sass emits a deprecation warning if you pass a `$weight` with no
units or with units other than `%` to `color.mix()` or `color.invert()`.
Currently, Sass emits a deprecation warning if you pass an index `$n` with units to
`list.nth()` or `list.set-nth()`.

### Phase 2

Expand Down
2 changes: 1 addition & 1 deletion source/documentation/breaking-changes/legacy-js-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ that contains a list of all Sass arguments, with asynchronous custom functions
returning a promise.

The modern API also uses a much more robust [`Value`] class that supports all
Sass value stypes, type assertions, and easy map and list lookups.
Sass value types, type assertions, and easy map and list lookups.

[`Value`]: /documentation/js-api/classes/Value/

Expand Down
8 changes: 4 additions & 4 deletions source/documentation/modules/color.md
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ title: sass:color
{% function 'color.is-legacy($color)', 'returns:boolean' %}
{% compatibility 'dart: "1.79.0"', 'libsass: false', 'ruby: false', 'feature: "$space"' %}{% endcompatibility %}

Returns whether `$color` is in a [legacy color space].
Returns whether `$color` is in a [legacy color space].

[legacy color space]: /documentation/values/colors#legacy-color-spaces

Expand All @@ -330,10 +330,10 @@ Returns whether `$color` is in a [legacy color space].
{% function 'color.is-missing($color, $channel)', 'returns:boolean' %}
{% compatibility 'dart: "1.79.0"', 'libsass: false', 'ruby: false', 'feature: "$space"' %}{% endcompatibility %}

Returns whether `$channel` is [missing] in `$color`. The `$channel` must be a
Returns whether `$channel` is [missing] in `$color`. The `$channel` must be a
quoted string.

[missing channel]: /documentation/values/colors#missing-channels
[missing]: /documentation/values/colors#missing-channels

{% codeExample 'color-is-missing', false %}
@use 'sass:color';
Expand All @@ -353,7 +353,7 @@ Returns whether `$channel` is [missing] in `$color`. The `$channel` must be a
{% function 'color.is-powerless($color, $channel, $space: null)', 'returns:boolean' %}
{% compatibility 'dart: "1.79.0"', 'libsass: false', 'ruby: false', 'feature: "$space"' %}{% endcompatibility %}

Returns whether `$color`'s `$channel` is [powerless] in `$space`, which
Returns whether `$color`'s `$channel` is [powerless] in `$space`, which
defaults to `$color`'s space. The `$channel` must be a quoted string and the
`$space` must be an unquoted string.

Expand Down
Loading