-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] Click to Copy #1177
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for sass-lang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like making the existing copy button match the new visual copy indicators 😃
$sl-color--text-medium-dark: #5e6470; // darker version of pale-sky | ||
$sl-color--action-dark: #a12d69; // darker version of action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be defined in terms of color.scale()
or color.adjust()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nex3 I can update that. I just quickly used a color app's down arrows until it passed. I can switch to a more readable format and look up the exact adjustments to use to make it work based on the brand colors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate it! We may also move to new color spaces for color conversions at some point, at which point knowing the underlying logic is valuable because we can just make the results more accurate.
Adds Click to Copy to input and output panes in the playground.
Addresses item 2 in #779.