Print verbose output in HRX format #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually we want to print this in diff format (see #27), but there's not an up-to-date diff library in Dart at the moment so this is a stop-gap measure for better output.
jathak
approved these changes
Sep 30, 2019
| @@ -106,12 +106,16 @@ class MigratorRunner extends CommandRunner<Map<Uri, String>> { | |||
|
|
|||
| if (argResults['dry-run']) { | |||
| print('Dry run. Logging migrated files instead of overwriting...\n'); | |||
There was a problem hiding this comment.
Would it make sense to remove this line or make it log to stderr so that the HRX output could be piped somewhere?
There was a problem hiding this comment.
I think we actually don't want people piping the output, since we plan to change the format to a diff at some point in the future anyway so it won't be reliably forwards-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we want to print this in diff format (see #27), but there's
not an up-to-date diff library in Dart at the moment so this is a
stop-gap measure for better output.