Skip to content

Commit

Permalink
Fix: update the logic to reduce concatenation
Browse files Browse the repository at this point in the history
  • Loading branch information
sarthaknagoshe2002 committed Dec 19, 2024
1 parent 9b3e07f commit 9083a54
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions packages/block-library/src/query-total/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ function render_block_core_query_total( $attributes, $content, $block ) {
$range_text = sprintf(
/* translators: 1: Start index of posts, 2: Total number of posts */
__( 'Displaying %1$s of %2$s' ),
'<strong>' . $start . '</strong>',
'<strong>' . $max_rows . '</strong>'
$start,
$max_rows
);
} else {
$range_text = sprintf(
/* translators: 1: Start index of posts, 2: End index of posts, 3: Total number of posts */
__( 'Displaying %1$s – %2$s of %3$s' ),
'<strong>' . $start . '</strong>',
'<strong>' . $end . '</strong>',
'<strong>' . $max_rows . '</strong>'
$start,
$end,
$max_rows
);
}

Expand All @@ -61,10 +61,12 @@ function render_block_core_query_total( $attributes, $content, $block ) {

case 'total-results':
default:
// translators: %d: Total number of posts.
$total_text = sprintf( _n( '%d result found', '%d results found', $max_rows ), $max_rows );
$output = sprintf(
'<p><strong>%d</strong> %s</p>',
$max_rows,
_n( 'result found', 'results found', $max_rows )
'<p>%s</p>',
$total_text,

);
break;
}
Expand Down

0 comments on commit 9083a54

Please sign in to comment.