Update to python 3 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
dmtucker
approved these changes
Mar 30, 2018
pyrc/bots.py
Outdated
| @@ -131,7 +132,7 @@ def parsefuncs(self, target, sender, message, funcs): | |||
|
|
|||
| if group_dict and (len(groups) > len(group_dict)): | |||
| # match.groups() also returns named parameters | |||
| raise "You cannot use both named and unnamed parameters" | |||
| raise IOError("You cannot use both named and unnamed parameters") | |||
There was a problem hiding this comment.
Maybe TypeError or ValueError would be better here?
pyrc/bots.py
Outdated
| @@ -95,8 +96,8 @@ def run_listeners(self, line): | |||
| callback(*match.groups()) | |||
|
|
|||
| def addhooks(self): | |||
| for func in self.__class__.__dict__.values(): | |||
| if callable(func) and hasattr(func, '_type'): | |||
| for func in list(self.__class__.__dict__.values()): | |||
There was a problem hiding this comment.
I think for func in vars(self.__class__).values(): would work.
pyrc/bots.py
Outdated
| @@ -5,7 +5,8 @@ | |||
| import re | |||
| import os | |||
|
|
|||
| import threads | |||
| from . import threads | |||
| import collections | |||
There was a problem hiding this comment.
nit: PEP8 would put collections in the group above.
Reorder imports, use vars(), and throw a TypeError instead of an IOError when the user passes in named and unnamed parameters.
dmtucker
approved these changes
Mar 31, 2018
|
One sec, fixing the conflicts now. |
Note: now we use func.__name__ instead of func.func_name in hooks.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I got some errors when I tried to use pyrc with a python 3 project, so I made a few changes for it to work with python 3. Though it probably breaks backward compatibility with python 2, so I dunno if you'd want to merge it.
Anyway, no pressure, just thought I'd put it out there :)