This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Allow reading Door Status when macros are stopping #1695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock that happens if someone happens to read Status of the Door exactly while a scan is stopping.
The problem is that the Status command takes the TangoMonitor of the Door device server, and then dev_status calls methods that are decorated by mAPI. This makes it wait until the running macro has stopped. It's holding the Monitor for this entire time and that causes all kinds of trouble. For example the logging fails on
push_change_event()
, and there are change events on other attributes as well during the stopping procedure. Every such attempt will fail with: