This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Fix udef elem expconf #1667
Open
Fix udef elem expconf #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 6ac7aa6 measurement groups does not accept configurations with undefined channels - an exception is raised. This collides with restoring configuration memorized values when a channel was undefined while still present, but disabled, in measurement groups configurations. Raise the said exception only if the channel is enabled in the measurement group.
sardana-org#1615 introduced bugs in expconf when a channel is undefined but still present in the measurement groups configurations. Fix it by disabling all cells of a disabled channels.
This reverts commit d9ecbc8.
Since 6ac7aa6 measurement groups does not accept configurations with undefined channels - an exception is raised. This collides with restoring configuration memorized values when a channel was undefined while still present, but disabled, in measurement groups configurations. Raise the said exception only if the channel is enabled in the measurement group. Previously d9ecbc8 also tried to fix this issue but it introduced a regression when disabling all channels in the measurement group.
|
Thanks @reszelaz ! I have tested it and no key error anymore. But the undefined channel is still shown in the channel list. I agree with you it would be a good idea to mark the undefined channel, so that users would know it from expconf that this one has been undefined. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes expconf issues introduced by #1615 and reported by @yimli in #1615 (comment) - see 3d146b6
One idea to improve it would be to somehow mark the row corresponding to a disabled and undefined channel in the expconf e.g. red background. Does someone know how to do it?
This PR also fixes one more issue with restoring the memorized value of the measurement group's configuration attribute containing disabled but undefined channels - see 244b5f2.
@yimli it would be great if you could test if it fixes the issues you observed. Many thanks!