WIP: Add fixtures for core tests #1474
Conversation
There was a problem hiding this comment.
Thanks @cpt-majkel for the PR. I still had no time to test it but I have a small suggestion already - see my inline comment. BTW, I think we could easily add an automatic test on the core level (without the need to use Tango).
src/sardana/pool/poolbasegroup.py
Outdated
| @@ -358,6 +358,8 @@ def stop(self): | |||
| self.debug("Stopping %s %s", ctrl.name, | |||
| [e.name for e in elements]) | |||
| try: | |||
| for el in elements: | |||
There was a problem hiding this comment.
I would move all the loop before of the try..except. Here we are just setting an internal flag, nothing can go wrong.
cpt-majkel
changed the title
|
@cpt-majkel, I reviewed the PR and it is looking very good. Especially the testing part with the fixtures. But I still have some questions about the testing part. Better let's organize some online meetings to discuss them. Meanwhile, in order to not block the integration of the fix and the Jan20 release, I will proceed to manually merge the very first three commits (1bca450, f573fcc and c47263e). |
reszelaz
changed the title
Related to #1421
Sets
stopflag on stop for each element in multiple elements movement. It results in correct (interrupted) state of the moveables and does not allow to apply backlash.