fix: Fix error that occurs when special characters are removed from column names #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data Signed-off-by: tashiro akira <[email protected]>
…ot mixed in the data
tashiro-akira
requested review from
kimusaku and
AkiraUra
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AkiraUra @kimusaku
Add action to eliminate duplicate column names when special characters are removed.
The results of the review were reflected.
・Review Comments
Thank you for the PR. The code of rename_dict is duplicated from the preprocess one.
Could you consider a way of removing the duplication?
・Corrected content
The processing to modify the column name is now a common plug-in.
・Review Comments
The current method fails when the renamed names are the same as original names.
For example, there are original columns Age , Age{} and Age1.
In the case, Age -> Age1, Age{} -> Age0, so there are two Age1 columns.
Could you consider the case?
・Corrected content
Fix column renaming to add a random number after the column name.
Add handling to rename a column if it is re-duplicated after renaming the column.