Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

feat: use es6 module #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mjeanroy
Copy link

@mjeanroy mjeanroy commented May 6, 2017

@sapegin Here is a PR for #58.

I did not want to make lot of changes so:

  • I just copy the jquery.mosaicflow.js to a new jquery.mosaicflow.m.js using ES6 import.
  • The jquery.mosaicflow.js is just the result of babel executed on jquery.mosaicflow.m.js file.

Copy link
Owner

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d put all generated files to dist folder. As a side effect you could avoid this ugly .m.js.

@mjeanroy
Copy link
Author

mjeanroy commented May 7, 2017

@sapegin That was my first idea, but people using the library directly (i.e without a module bundler, or without something reading the main entry point) will need to update the path to the jquery.mosaicflow.js to point to the dist folder (probably not a big problem since it will be very easy to fix).

I also suggest to move the jquery.mosaicflow.m.js to src/jquery.mosaicflow.js because keeping jquery.mosaicflow.js at the root will not throw an error for people currently pointing to it.

What do you think?

@sapegin
Copy link
Owner

sapegin commented May 8, 2017

I don’t know how many people still use the library but I won’t mind path change. So src + dist and no .m :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants