Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only offer secure ciphers in kubelet server #883

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

jknipper
Copy link
Collaborator

@jknipper jknipper commented Mar 6, 2024

This config change limits kubelet server to only offer TLS 1.3 ciphers. Those are:

 x1302   TLS_AES_256_GCM_SHA384            ECDH 253   AESGCM      256      TLS_AES_256_GCM_SHA384                             
 x1303   TLS_CHACHA20_POLY1305_SHA256      ECDH 253   ChaCha20    256      TLS_CHACHA20_POLY1305_SHA256                       
 x1301   TLS_AES_128_GCM_SHA256            ECDH 253   AESGCM      128      TLS_AES_128_GCM_SHA256       

See attachment for detailed scan.

References:
https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/#kubelet-config-k8s-io-v1beta1-KubeletConfiguration
https://pkg.go.dev/crypto/tls#pkg-constants
https://nvd.nist.gov/vuln/detail/CVE-2016-2183

testssl.txt

@SuperSandro2000
Copy link
Member

I would go on the save side and also allow TLS 1.2. Not everything support 1.3.

@jknipper
Copy link
Collaborator Author

Ok, I added a cipher list which is what we use in the apiserver plus TLS_CHACHA20_POLY1305_SHA256 that is offered in TLS1.3 default configuration. Also attached scan results for TLS1.2.

@jknipper
Copy link
Collaborator Author

testssl12.txt

@jknipper jknipper changed the title Only offer TLS 1.3 in kubelet server Only offer secure ciphers in kubelet server Mar 12, 2024
@jknipper jknipper merged commit fab2229 into master Mar 12, 2024
2 checks passed
@jknipper jknipper deleted the kubelet_server_tls13 branch March 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants