Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod namespace env to etcd backup sidecar #715

Closed
wants to merge 1 commit into from
Closed

Add pod namespace env to etcd backup sidecar #715

wants to merge 1 commit into from

Conversation

jknipper
Copy link
Collaborator

Addresses #714

@databus23
Copy link
Member

What is this actually doing? I'm a bit confused why it needs the namespace now that I think about it. The namespace for our deployments will always by kubernikus. How does this prevent from mounting the wrong volume...

@jknipper
Copy link
Collaborator Author

See https://github.com/gardener/etcd-backup-restore/blob/b68a54ea05c6d33a91adfcfd872b667357268303/pkg/initializer/validator/datavalidator.go#L93

Looks like they write a file with the namespace in it to the volume and verify it on startup.

@databus23
Copy link
Member

Closing after discussing in out dev call. We could add kluster name as POD_NAMESPACE but we are not sure why

@databus23 databus23 closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@databus23 databus23 Awaiting requested review from databus23 databus23 is a code owner

@BugRoger BugRoger Awaiting requested review from BugRoger

@auhlig auhlig Awaiting requested review from auhlig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jknipper @databus23