Uncomment cluster version check (#815)

sapcc · Jun 22, 2023 · ff76894 · ff76894
1 parent 7b97cf9
commit ff76894
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/pkg/util/kluster.go b/pkg/util/kluster.go
@@ -147,17 +147,16 @@ func KlusterVersionConstraint(kluster *v1.Kluster, constraint string) (bool, err
 
 func KlusterNeedsUpgrade(kluster *v1.Kluster) (bool, error) {
 
-	// from, err := semver.NewVersion(kluster.Status.ApiserverVersion)
-	// if err != nil {
-	// 	return false, err
-	// }
-
-	// to, err := semver.NewVersion(kluster.Spec.Version)
-	// if err != nil {
-	// 	return false, err
-	// }
-	// return from.Compare(to) != 0 && (from.Minor() == to.Minor() || from.Minor()+1 == to.Minor()), nil
-	return false, nil
+	from, err := semver.NewVersion(kluster.Status.ApiserverVersion)
+	if err != nil {
+		return false, err
+	}
+
+	to, err := semver.NewVersion(kluster.Spec.Version)
+	if err != nil {
+		return false, err
+	}
+	return from.Compare(to) != 0 && (from.Minor() == to.Minor() || from.Minor()+1 == to.Minor()), nil
 }
 
 func KlusterPodsReadyCount(kluster *v1.Kluster, podLister listers_core_v1.PodLister) (int, int, error) {