Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Add support for xmit_hash_policy (bsc#1033917) #40

Open
wants to merge 1 commit into
base: stable/sap/3.0
Choose a base branch
from

Conversation

vuntz
Copy link

@vuntz vuntz commented Jun 28, 2017

(Backport of crowbar#1231 -- required for a partner.)

Add support for the xmit_hash_policy property of NIC bonding to be queried
and set, as well as adding the existing miimon property and new
xmit_hash_policy property to the network schema.

Add support for miimon to be set (or overloaded) on a per-network basis,
like xmit_hash_policy.

Drive-by correctly setting miimon rather than hardcoding 100 for the
interfaces(5) template.

(cherry picked from commit 08559ef)
(cherry picked from commit d58f6dd)

Add support for the xmit_hash_policy property of NIC bonding to be queried
and set, as well as adding the existing miimon property and new
xmit_hash_policy property to the network schema.

Add support for miimon to be set (or overloaded) on a per-network basis,
like xmit_hash_policy.

Drive-by correctly setting miimon rather than hardcoding 100 for the
interfaces(5) template.

(cherry picked from commit 08559ef)
(cherry picked from commit d58f6dd)
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants