-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with stable/3.0 part of the rails app for apply_role improvements #18
base: stable/sap/3.0
Are you sure you want to change the base?
Conversation
There was an attempt to fix the internal API so that ServiceObject.apply_role always returns [int, str], but this actually breaks the UI-only path in the controller. So revert this and document with a FIXME that this should eventually be fixed by moving everything to [int, hash] where we will have more freedom. https://bugzilla.suse.com/show_bug.cgi?id=989958 (cherry picked from commit 1ad0664) (cherry picked from commit ec17274)
We catch all exceptions that aren't caught from this method to set the status of the proposal to "failed", to avoid people being blocked by a proposal staying forever in "applying". This helps with https://bugzilla.suse.com/show_bug.cgi?id=840255 (cherry picked from commit 43bc948) (cherry picked from commit 50ec9c0)
Was part of crowbar#560 (cherry picked from commit 7d12ecb) (cherry picked from commit 457222b)
982ccde
to
5d1b187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.ymlAlignWith
has been renamed toEnforcedStyleAlignWith
@logger.debug "batches: #{batches.inspect}" | ||
|
||
# Cache attributes that are useful later on | ||
pre_cached_nodes.each do |node_name, node| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the line next if node.nil?
here as well, to skip nodes, that no longer exists, but still referenced in chef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some logging improvements as well as changes to make the code more solid and deal better with exceptions when clicking on "apply".
@tpatzig with these fixes, the issue with lock files that are blocking chef-client from running on nodes will not be triggered anymore.