solution to issue#25 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wabri
requested changes
Aug 8, 2024
Wabri
approved these changes
Aug 9, 2024
rainerleber
approved these changes
Aug 10, 2024
| @@ -87,12 +87,13 @@ | |||
| # Get SAP Facts | |||
| - name: Run sap_facts module to gather SAP facts | |||
| community.sap_libs.sap_system_facts: | |||
| param: "{{ sap_facts_param }}" | |||
| # param: "{{ sap_facts_param }}" | |||
There was a problem hiding this comment.
Maybe direkt deletion instead of commenting out the line
|
As all reviewer approved the PR I have merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check my solution to the issue#25 in role sap_control.
The solution adopts to the namespace (ansible_facts.sap instead of sap_facts) when calling the module
community.sap_libs.sap_system_facts from the playbook tasks/main.yml.
It also corrects the names of variables that are used in tasks/prepare.yml used in the call of the playbook tasks/sapcontrol.yml.