Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workflows): open branch from dev not from main #861

Closed
wants to merge 1 commit into from
Closed

fix(workflows): open branch from dev not from main #861

wants to merge 1 commit into from

Conversation

Wabri
Copy link
Member

@Wabri Wabri commented Sep 10, 2024

Closes #858

@Wabri Wabri self-assigned this Sep 10, 2024
berndfinger
berndfinger approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I haven't tested it).

@Wabri
Copy link
Member Author

Wabri commented Sep 12, 2024

You are right, here the pipeline that work fine in my fork https://github.com/Wabri/community.sap_install/actions/runs/10795468219/job/29942214043

It created the correct issue starting with the right version of ansible:

----- Check ansible -----
INFO: current version 9.5.1
INFO: latest version 10.3.0
INFO: Issue created -> https://github.com/Wabri/community.sap_install/issues/205

And this is the commit related to the change https://github.com/Wabri/community.sap_install/commit/07495b73bc66af13a1bbd77ba858a330d95d45c7

@Wabri Wabri closed this by deleting the head repository Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berndfinger berndfinger berndfinger approved these changes

@marcelmamula marcelmamula Awaiting requested review from marcelmamula

Assignees

@Wabri Wabri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wabri @berndfinger