Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Return default value of fieldvalue when possible #252

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Commits on Aug 5, 2019

  1. Configuration menu
    Copy the full SHA
    02157fb View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Code cleanup

    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    cc29bbe View commit details
    Browse the repository at this point in the history
  2. Adds a test for default values

    Also, refactors the test_bunch_subclass so that pytest fixtures are used
    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1ebec2a View commit details
    Browse the repository at this point in the history
  3. Since __getattr__ now returns the default value when a fieldvalue is …

    …not provided, asserting that Do_Zone_Sizing_Calculation will return "No" weather or not defaultvalues=True or False. Although the repr() of the EpBunch still behaves properly and won't print the default values. I think this is the correct behavior.
    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    610a345 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d3ccf4 View commit details
    Browse the repository at this point in the history
  5. Extends the default logic to all returned values that are equal to an…

    … empty string
    
    If an empty string is returned, will try to return the default value instead if it exists. This behavior is compatible with the the way EnergyPlus handles missing fields
    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    4f9ea7a View commit details
    Browse the repository at this point in the history
  6. Adds another test

    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    a4ec709 View commit details
    Browse the repository at this point in the history
  7. Fixes an issue where run errors could not be read because of suffix d…

    …ifferent than "eplus"
    
    Now uses glob with a wildcard to catch the first *out.err file
    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b713149 View commit details
    Browse the repository at this point in the history
  8. Adds expandobject=True to testrunners to assert tests

    Running these tests locally with env var EPPY_INTEGRATION=1 would throw errors on EnergyPlus' side; it asks for the expandobject subroutine
    samuelduchesne committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    fd8789c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Configuration menu
    Copy the full SHA
    79db7d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0d2ef5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Black

    samuelduchesne committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e6375ac View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Configuration menu
    Copy the full SHA
    1422b91 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Configuration menu
    Copy the full SHA
    8216057 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f8eba0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a84753c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb671c7 View commit details
    Browse the repository at this point in the history
  5. Using regex improves speed (a little bit slower then encode/decode) b…

    …ut keeps same behavior
    
    tests are happy
    samuelduchesne committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    cab7bda View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    588b3fe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    841d376 View commit details
    Browse the repository at this point in the history