#99 Add tab that displays the logs #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagoparradev
requested changes
Feb 7, 2024
| <content>Playlist_Record_Page</content> | ||
| <formFactor>Small</formFactor> | ||
| <comment | ||
| >Action override created by Lightning App Builder during activation.</comment> |
There was a problem hiding this comment.
why are you adding a space after ? check your changes remember you only need to add what is relevant not all changes are aceptable
| @@ -90,6 +98,7 @@ | |||
| <tabs>Playlist__c</tabs> | |||
| <tabs>Album__c</tabs> | |||
| <tabs>ClientCredential__c</tabs> | |||
| <tabs>log__c</tabs> | |||
| ); | ||
| // test | ||
| Test.startTest(); | ||
| EventBus.publish(errorEvent); |
There was a problem hiding this comment.
no need to add that space
| EventBus.publish(errorEvent); | ||
| Test.stopTest(); | ||
| //assert | ||
| List<Log__c> error = [SELECT ApexError__c FROM Log__c WHERE ApexError__c = 'error']; |
There was a problem hiding this comment.
you are hardcoding this value do
WHERE ApexError__c =: errorEvent.error
| <PermissionSet xmlns="http://soap.sforce.com/2006/04/metadata"> | ||
| <fieldPermissions> | ||
| <editable>true</editable> | ||
| <field>log__c.ApexError__c</field> |
There was a problem hiding this comment.
again objects should start with Caps
| @@ -0,0 +1,17 @@ | |||
| trigger ShowErrosInObject on Spotify_Request_Log__e(after insert) { | |||
There was a problem hiding this comment.
why is this file name? does not make sense
it should be SpotifyRequestLogTrigger
| @@ -0,0 +1,16 @@ | |||
| @isTest | |||
| private class SpotifyRequestLogTrigger { | |||
| @isTest static void spotifyRequestLogTrigger() { | |||
There was a problem hiding this comment.
method name should reflect what is being tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.