-#96 changes for the code

santiagoparradev · Feb 26, 2024 · 54afb81 · 54afb81
1 parent 2ddf23d
commit 54afb81
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 24 deletions.
diff --git a/force-app/main/default/classes/service/SyncTrack.cls b/force-app/main/default/classes/service/SyncTrack.cls
@@ -98,23 +98,18 @@ public class SyncTrack {
 
     private static Map<String, TrackArtist__c> getTrackArtist(List<SimplefieldArtistObject> artists, String trackId) {
 
-        Map<String, TrackArtist__c> trackArtistMap = new Map<String, TrackArtist__c>();
+        Map<String, TrackArtist__c> result = new Map<String, TrackArtist__c>();
 
         for (SimplefieldArtistObject artist : artists) {
 
             String key = artist.id + trackId;
             TrackArtist__c trackArtistRecord = new TrackArtist__c(
                 TrackArtistKey__c = key,
-                Track__r = new Track__c(
-                    SpotifyId__c = trackId
-                ),
-                Artist__r = new Artist__c(
-                    SpotifyId__c = artist.id
-                )
-            );
-            trackArtistMap.put(key, trackArtistRecord);
+                Track__r = new Track__c(SpotifyId__c = trackId),
+                Artist__r = new Artist__c(SpotifyId__c = artist.id));
+            result.put(key, trackArtistRecord);
         }
 
-        return trackArtistMap;
+        return result;
     }
 }
diff --git a/force-app/main/default/classes/service/test/SyncTrackTest.cls b/force-app/main/default/classes/service/test/SyncTrackTest.cls
@@ -8,25 +8,31 @@ private class SyncTrackTest {
 
         addResponse(responseList, '{"access_token":"1111"}');
         addResponse(responseList, '{"total":2,"items":[{"id":"0"}]}');
-        addResponse(responseList, '{"items":[{"track":{' +
-            '"name":"track name",' +
-            '"id":"trackId",' +
-            '"explicit":true,' +
-            '"album":{"name":null,"id":"albumId"},' +
-            '"artists":[{"id":"artistId"}]}}]}');
+        addResponse(
+            responseList,
+            '{"items":[{' +
+                '"track":{' +
+                    '"name":"track name",' +
+                    '"id":"trackId",' +
+                    '"explicit":true,' +
+                    '"album":{"name":null,"id":"albumId"},' +
+                    '"artists":[{"id":"artistId"}]}}]}');
         addResponse(responseList, '{"total":2,"items":[{"id":"1"}]}');
-        addResponse(responseList, '{"items":[{"track":{' + 
-            '"name":"track name",' +
-            '"id":"trackId1",' +
-            '"explicit":true,' +
-            '"album":{"name":null,"id":"albumId1"},' +
-            '"artists":[{"id":"artistId1"}]}}]}');
+        addResponse(
+            responseList,
+            '{"items":[{' +
+                '"track":{' +
+                    '"name":"track name",' +
+                    '"id":"trackId1",' +
+                    '"explicit":true,' +
+                    '"album":{"name":null,"id":"albumId1"},' +
+                    '"artists":[{"id":"artistId1"}]}}]}');
         Test.setMock(HttpCalloutMock.class, new HttpCalloutMockFactory(responseList));       
         Album__c album = new Album__c(SpotifyId__c = 'albumId');
-        Album__c album1 = new Album__c(SpotifyId__c = 'albumId1');
+        Album__c secondAlbum = new Album__c(SpotifyId__c = 'albumId1');
 
         insert album;
-        insert album1;
+        insert secondAlbum;
 
         List<ClientCredential__c> newCredentials = new List<ClientCredential__c>{
             new ClientCredential__c(