-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use Web Crypto API #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Replace the Node.js `crypto` API with the Web Crypto API, enabling usage in more environments. All assertion/checking functions are now async, eg return Promises instead of straight booleans. BREAKING CHANGE: Only Node.js version 18 and higher is now supported.
Closed
stipsan
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome rewrite 🥳
Comment on lines
60
to
+61
- os: ubuntu-latest | ||
node: lts/-1 | ||
node: lts/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block can be deleted as it's already included in the base matrix 😌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #40
Fixes #38
While the idea of using the Web Crypto API is fine, it requires a significant amount of changes due to the async nature of the API. I still think it is worth moving to however, since it broadens the range of ecosystems we can support (Browser, Deno, Bun, workers etc) so this PR switches to it and moves to async functions.
Also removes the
base64url
dependency, since we can achieve the same in plain JS and avoid having to bundle.Now requires Node 18 or higher.