Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest to v3 #8371

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

chore: upgrade vitest to v3 #8371

wants to merge 5 commits into from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 22, 2025

Description

(note: builds upon the changes in #8370)

Upgrades vitest to v3

What to review

Does the test pass?

Testing

Tests should pass

Notes for release

n/a – internal

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:48am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:48am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:48am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 11:48am
test-next-studio ⬜️ Ignored (Inspect) Jan 24, 2025 11:48am

Copy link

socket-security bot commented Jan 22, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, network, shell, unsafe +85 11.7 MB antfu, oreanno, patak, ...1 more

View full report↗︎

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Component Testing Report Updated Jan 24, 2025 11:54 AM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 59s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 29s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 22, 2025

⚡️ Editor Performance Report

Updated Fri, 24 Jan 2025 11:54:05 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 26.0 efps (39ms) -6ms (-12.5%)
article (body) 72.5 efps (14ms) 67.6 efps (15ms) +1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 26.3 efps (38ms) +0ms (-/-%)
article (string inside array) 23.3 efps (43ms) 23.3 efps (43ms) +0ms (-/-%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 60.6 efps (17ms) 62.5 efps (16ms) -1ms (-3.0%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.4 efps (52ms) 18.9 efps (53ms) +2ms (+2.9%)
synthetic (string inside object) 19.2 efps (52ms) 19.0 efps (53ms) +1ms (+1.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 67ms 76ms 551ms 1107ms 11.2s
article (body) 14ms 16ms 18ms 189ms 258ms 5.6s
article (string inside object) 38ms 41ms 46ms 165ms 140ms 6.8s
article (string inside array) 43ms 45ms 49ms 70ms 170ms 7.1s
recipe (name) 19ms 20ms 23ms 39ms 0ms 6.5s
recipe (description) 17ms 18ms 19ms 30ms 0ms 4.3s
recipe (instructions) 5ms 7ms 7ms 17ms 0ms 3.0s
synthetic (title) 52ms 53ms 58ms 320ms 731ms 13.0s
synthetic (string inside object) 52ms 59ms 78ms 452ms 1048ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 45ms 71ms 449ms 847ms 10.6s
article (body) 15ms 16ms 19ms 136ms 70ms 5.0s
article (string inside object) 38ms 44ms 60ms 176ms 207ms 7.1s
article (string inside array) 43ms 44ms 50ms 220ms 244ms 7.1s
recipe (name) 19ms 20ms 24ms 38ms 0ms 6.8s
recipe (description) 16ms 18ms 19ms 31ms 0ms 4.3s
recipe (instructions) 5ms 7ms 8ms 18ms 0ms 3.1s
synthetic (title) 53ms 55ms 61ms 295ms 686ms 11.8s
synthetic (string inside object) 53ms 54ms 72ms 249ms 377ms 7.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

ricokahler
ricokahler previously approved these changes Jan 22, 2025
binoy14
binoy14 previously approved these changes Jan 24, 2025
Base automatically changed from upgrade-vite-v6 to next January 30, 2025 14:03
@bjoerge bjoerge dismissed binoy14’s stale review January 30, 2025 14:03

The base branch was changed.

@bjoerge bjoerge dismissed ricokahler’s stale review January 30, 2025 14:03

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants