Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Navbar link for Tasks tool #8257

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Jan 13, 2025

Description

Scenario Before After
Desktop navbar Screenshot 2025-01-14 at 10 03 04 Screenshot 2025-01-14 at 10 02 31
Mobile tray Screenshot 2025-01-14 at 10 03 14 Screenshot 2025-01-14 at 10 02 47

What to review

  • There is now support for a custom rendered for plugin navbar links, in addition to just defining a string and icon. This is used by the new tasks navbar link

Testing

No new tests needed, same functionality as before

Notes for release

Studio plugins may now define a custom render method for navbar icons and actions

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:22pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:22pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 13, 2025 9:22pm
test-next-studio ⬜️ Ignored (Inspect) Jan 13, 2025 9:22pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 13, 2025 9:25 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 13 Jan 2025 21:31:20 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 24.4 efps (41ms) +3ms (+7.9%)
article (body) 63.9 efps (16ms) 67.6 efps (15ms) -1ms (-/-%)
article (string inside object) 25.0 efps (40ms) 24.4 efps (41ms) +1ms (+2.5%)
article (string inside array) 22.2 efps (45ms) 20.8 efps (48ms) +3ms (+6.7%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 58.8 efps (17ms) 55.6 efps (18ms) +1ms (+5.9%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.0 efps (50ms) 18.9 efps (53ms) +3ms (+6.0%)
synthetic (string inside object) 21.3 efps (47ms) 20.4 efps (49ms) +2ms (+4.3%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 52ms 65ms 427ms 697ms 10.7s
article (body) 16ms 17ms 20ms 195ms 252ms 5.6s
article (string inside object) 40ms 45ms 53ms 90ms 157ms 7.0s
article (string inside array) 45ms 47ms 52ms 173ms 192ms 7.2s
recipe (name) 20ms 21ms 23ms 45ms 0ms 6.9s
recipe (description) 17ms 18ms 21ms 25ms 0ms 4.4s
recipe (instructions) 5ms 7ms 7ms 10ms 0ms 3.1s
synthetic (title) 50ms 56ms 76ms 421ms 997ms 12.8s
synthetic (string inside object) 47ms 48ms 51ms 243ms 104ms 7.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 44ms 67ms 442ms 798ms 11.4s
article (body) 15ms 17ms 24ms 75ms 121ms 5.3s
article (string inside object) 41ms 42ms 47ms 188ms 150ms 7.2s
article (string inside array) 48ms 50ms 59ms 312ms 493ms 8.1s
recipe (name) 20ms 23ms 26ms 41ms 8ms 6.9s
recipe (description) 18ms 20ms 22ms 40ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 11ms 0ms 3.1s
synthetic (title) 53ms 57ms 66ms 110ms 514ms 12.3s
synthetic (string inside object) 49ms 52ms 55ms 459ms 959ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 marked this pull request as ready for review January 14, 2025 10:09
@jordanl17 jordanl17 requested a review from a team as a code owner January 14, 2025 10:09
@jordanl17 jordanl17 requested review from ricokahler and removed request for a team January 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant