fix(deps): upgrade `vite` to v6 #7995

rexxars · 2024-12-09T19:34:00Z

Description

Upgrades vite to the latest version (v6).

~~Marked as draft as we want to make sure this is safe - v6 is a fairly large refactor (on their end).~~ Edit: v6 has been out for a while now, so removing draft state.

I had to lock the vite dependency version because vitest is using v5 which causes some type errors in the monorepo. vitest@3 will be released in January, with full support for vite@6.

What to review

Give it a test, see how it feels! Does anything break?
There's a prerelease you can use to test it on a local studio, under the upgrade-vite-v6 branch on npm.

Testing

Commands involved:

sanity dev
sanity build
sanity preview

Notes for release

Upgrades vite to version 6

vercel · 2024-12-09T19:34:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 3:59pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 3:59pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2025 3:59pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Jan 13, 2025 3:59pm
test-next-studio	⬜️ Ignored (Inspect)	Visit Preview		Jan 13, 2025 3:59pm

socket-security · 2024-12-09T19:34:36Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/[email protected]	None	`+3`	2.69 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+3`	2.67 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`0`	2.55 MB	nicolo-ribaudo
npm/@codemirror/[email protected] 🔁 npm/@codemirror/[email protected]	None	`+1`	472 kB	marijn
npm/@codemirror/[email protected] 🔁 npm/@codemirror/[email protected]	Transitive: environment	`+3`	735 kB	adrianheine, marijn
npm/@codemirror/[email protected] 🔁 npm/@codemirror/[email protected]	None	`+1`	444 kB	marijn
npm/@codemirror/[email protected] 🔁 npm/@codemirror/[email protected]	None	`+2`	1.19 MB	adrianheine, marijn
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected]	Transitive: environment, eval	`+8`	8.35 MB	sanity-io
npm/@sanity/[email protected]	None	`0`	533 kB	sanity-io
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected]	Transitive: environment, network	`+4`	4.23 MB	armandocerna, ash, atombender, ...62 more
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected]	Transitive: environment, filesystem, shell, unsafe	`+25`	13.7 MB	armandocerna, ash, atombender, ...63 more
npm/@types/[email protected] 🔁 npm/@types/[email protected]	None	`0`	20.6 kB	types
npm/@types/[email protected] 🔁 npm/@types/[email protected]	None	`0`	796 kB	types
npm/[email protected]	environment Transitive: filesystem	`+6`	2.4 MB	probablyup

🚮 Removed packages: npm/@portabletext/[email protected]

View full report↗︎

github-actions · 2024-12-09T19:34:53Z

No changes to documentation

github-actions · 2024-12-09T19:41:51Z

Component Testing Report Updated Jan 13, 2025 4:06 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 6s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	13s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	39s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	51s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 8s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 28s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 39s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 42s	21	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-12-09T19:46:14Z

⚡️ Editor Performance Report

Updated Mon, 13 Jan 2025 16:06:45 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	23.8 efps (42ms)	21.7 efps (46ms)	+4ms (+9.5%)	✅
article (body)	61.2 efps (16ms)	62.9 efps (16ms)	-0ms (-2.8%)	✅
article (string inside object)	27.0 efps (37ms)	23.3 efps (43ms)	+6ms (+16.2%)	✅
article (string inside array)	23.3 efps (43ms)	20.4 efps (49ms)	+6ms (+14.0%)	✅
recipe (name)	50.0 efps (20ms)	50.0 efps (20ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	55.6 efps (18ms)	+1ms (+5.9%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	18.5 efps (54ms)	19.6 efps (51ms)	-3ms (-5.6%)	✅
synthetic (string inside object)	19.6 efps (51ms)	18.9 efps (53ms)	+2ms (+3.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	42ms	56ms	71ms	414ms	664ms	11.2s
article (body)	16ms	19ms	20ms	94ms	110ms	5.3s
article (string inside object)	37ms	41ms	47ms	196ms	257ms	6.8s
article (string inside array)	43ms	45ms	48ms	65ms	147ms	6.8s
recipe (name)	20ms	23ms	30ms	56ms	0ms	7.1s
recipe (description)	17ms	18ms	20ms	44ms	0ms	4.6s
recipe (instructions)	5ms	6ms	7ms	9ms	0ms	3.0s
synthetic (title)	54ms	55ms	76ms	291ms	722ms	13.1s
synthetic (string inside object)	51ms	55ms	61ms	482ms	1030ms	8.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	46ms	65ms	83ms	492ms	873ms	11.7s
article (body)	16ms	19ms	28ms	165ms	219ms	5.7s
article (string inside object)	43ms	44ms	49ms	163ms	193ms	7.1s
article (string inside array)	49ms	50ms	57ms	241ms	413ms	7.7s
recipe (name)	20ms	22ms	23ms	31ms	0ms	6.7s
recipe (description)	18ms	19ms	22ms	31ms	0ms	4.6s
recipe (instructions)	5ms	6ms	7ms	9ms	0ms	3.0s
synthetic (title)	51ms	53ms	57ms	118ms	270ms	12.4s
synthetic (string inside object)	53ms	57ms	67ms	252ms	836ms	8.1s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

socket-security · 2025-01-13T15:52:59Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	CI
License Policy Violation	npm/[email protected]	License: CC-BY-SA-4.0 - Not allowed by license policy (package/dist/compiled/glob/LICENSE, package/dist/compiled/glob/LICENSE)	⚠︎

View full report↗︎

Next steps

What is a license policy violation?

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/[email protected]

bjoerge

Thank you for this, @rexxars! <3

vercel bot deployed to Preview – test-next-studio December 9, 2024 19:38 View deployment

rexxars force-pushed the upgrade-vite-v6 branch from 647ee30 to cb4738d Compare December 11, 2024 21:15

vercel bot deployed to Preview – performance-studio December 11, 2024 21:22 View deployment

vercel bot deployed to Preview – page-building-studio December 11, 2024 21:22 View deployment

vercel bot deployed to Preview – test-studio December 11, 2024 21:23 View deployment

vercel bot deployed to Preview – test-next-studio December 11, 2024 21:31 View deployment

bjoerge force-pushed the next branch from d2f2254 to 1d75764 Compare December 20, 2024 10:29

binoy14 force-pushed the next branch from 8e29ec5 to babdfe4 Compare December 20, 2024 17:20

rexxars added 2 commits January 13, 2025 07:45

fix(deps): upgrade vite to v6

2620ca8

chore: temporary override to make vitest use vite 6

8ccdff6

rexxars force-pushed the upgrade-vite-v6 branch from cb4738d to 8ccdff6 Compare January 13, 2025 15:51

rexxars marked this pull request as ready for review January 13, 2025 15:52

rexxars requested a review from a team as a code owner January 13, 2025 15:52

rexxars requested review from RitaDias and bjoerge and removed request for a team January 13, 2025 15:52

vercel bot deployed to Preview – performance-studio January 13, 2025 15:58 View deployment

vercel bot deployed to Preview – page-building-studio January 13, 2025 15:58 View deployment

vercel bot deployed to Preview – test-studio January 13, 2025 15:59 View deployment

bjoerge approved these changes Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): upgrade `vite` to v6 #7995

fix(deps): upgrade `vite` to v6 #7995

rexxars commented Dec 9, 2024 •

edited

Loading

vercel bot commented Dec 9, 2024 •

edited

Loading

socket-security bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

socket-security bot commented Jan 13, 2025

bjoerge left a comment

fix(deps): upgrade vite to v6 #7995

Are you sure you want to change the base?

fix(deps): upgrade vite to v6 #7995

Conversation

rexxars commented Dec 9, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Dec 9, 2024 • edited Loading

socket-security bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024 • edited Loading

github-actions bot commented Dec 9, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

socket-security bot commented Jan 13, 2025

Next steps

bjoerge left a comment

Choose a reason for hiding this comment

fix(deps): upgrade `vite` to v6 #7995

fix(deps): upgrade `vite` to v6 #7995

rexxars commented Dec 9, 2024 •

edited

Loading

vercel bot commented Dec 9, 2024 •

edited

Loading

socket-security bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading