-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): move ToastProvider
inside LocaleProvider
#6145
Draft
juice49
wants to merge
1
commit into
next
Choose a base branch
from
fix/sdx-1214-toast-locale-context
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Mar 28, 2024 5:55 PM (UTC)
|
9caf5d8
to
691aad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug that occurs when a
Toast
component contains aTranslate
component, because theTranslate
component now depends onLocaleContext
.Notably, this occurs when some document operations (e.g. publication) succeed.
This is caused by the order of the providers.
ToastProvider
is a parent ofLocaleProvider
, but it needs to be a descendant of it. This branch adjusts the order of the providers in order to fix the problem.What to review
ToastProvider
down the tree. It doesn't appear anything further up the tree depends on it. Is that correct?ErrorLogger
down the tree (because it depends onToastProvider
); notably, it is now insideStudioErrorBoundary
. Are there any concerns with that?Testing
Notes for release
Translate
component appeared inside aToast
component.