Fix PacBio pool edit data loading

[BenTopping]

Changes proposed in this pull request

• Adds DataFetcher to Pacbio Pool Edit page to standardise data fetching and hopefully prevent race condition causing CI failures.
• Small tweak to spinner style

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[stevieing]

I think the discussion about using params is an interesting one. Could we use types?

[stevieing]

Could we use a type?

[BenTopping]

That was an old comment I copied over, which I think i wrote, but I think this pattern is actually fine. But there is an issue here because if we use a random string in the URL, instead of new, it will try and look for a pool with that string, as we are only checking its not 'new'. Doesn't seem very safe. I don't have time to look before my leave but happy for you to have a go if you want, if not will look in the new year.

[stevieing]

I don’t think it is necessary to change now. I would prefer to get this into UAT so we can fix ci. Just add a comment and merge. From: Ben Topping ***@***.***> Reply to: sanger/traction-ui ***@***.***> Date: Thursday, 14 December 2023 at 14:59 To: sanger/traction-ui ***@***.***> Cc: Stephen Inglis ***@***.***>, Review requested ***@***.***> Subject: Re: [sanger/traction-ui] Fix PacBio pool edit data loading (PR #1450) [EXT] @BenTopping commented on this pull request.

________________________________ In src/views/pacbio/PacbioPoolCreate.vue [github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sanger_traction-2Dui_pull_1450-23discussion-5Fr1426836792&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=tgCcNLWA7AMTZ9NbmhpTw6wpauzjkRuyJ-I2jTkrnM77VinDACtIyy57FObenrSO&s=_tA_p7zEs-Pu7UkJr1TEmcXUOG9ax2tHnzrdxUYG1I8&e=>:

@@ -98,8 +84,19 @@ export default {

'findPacbioPlate', 'findPacbioTube', ]), + async fetchPoolsData() { + this.$store.commit('traction/pacbio/poolCreate/clearPoolData') + await this.fetchPacbioTagSets().then(this.alertOnFail) + + // We should come up with a better solution to identify 'new' pools That was an old comment I copied over, which I think i wrote, but I think this pattern is actually fine. But there is an issue here because if we use a random string it will try and look for a pool with that string, as we are only checking its not 'new'. Doesn't seem very safe. I don't have time to look before my leave but happy for you to have a go if you want, if not will look in the new year. — Reply to this email directly, view it on GitHub [github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sanger_traction-2Dui_pull_1450-23discussion-5Fr1426836792&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=tgCcNLWA7AMTZ9NbmhpTw6wpauzjkRuyJ-I2jTkrnM77VinDACtIyy57FObenrSO&s=_tA_p7zEs-Pu7UkJr1TEmcXUOG9ax2tHnzrdxUYG1I8&e=>, or unsubscribe [github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAD6ZH7O7F6PTZF32CHTKNLYJMH6DAVCNFSM6AAAAABATIX226VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBSGAYTENZRGQ&d=DwMFaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=PioAYl_Zz9lnGwJRms8MsEB0E-grNRW-ut-_gAGl70g&m=tgCcNLWA7AMTZ9NbmhpTw6wpauzjkRuyJ-I2jTkrnM77VinDACtIyy57FObenrSO&s=2TgisonuH_GfL9-XCodOZESwvsHt4nXSzThXGlW9-qc&e=>. You are receiving this because your review was requested.Message ID: ***@***.***>

…

-- The Wellcome Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is Wellcome Sanger Institute, Wellcome Genome Campus, Hinxton, CB10 1SA