Add lock in is_blk_alloced to fix concurrency issue. (eBay#310)

There seems a concurrency issue when is blk alloced fails in test_data_service.
sanebay · Feb 8, 2024 · c8021ab · c8021ab
1 parent 6922c89
commit c8021ab
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/conanfile.py b/conanfile.py
@@ -5,7 +5,7 @@
 
 class HomestoreConan(ConanFile):
     name = "homestore"
-    version = "5.1.3"
+    version = "5.1.4"
 
     homepage = "https://github.com/eBay/Homestore"
     description = "HomeStore Storage Engine"

diff --git a/src/lib/device/virtual_dev.cpp b/src/lib/device/virtual_dev.cpp
@@ -149,7 +149,7 @@ folly::Future< std::error_code > VirtualDev::async_format() {
 }
 
 bool VirtualDev::is_blk_alloced(BlkId const& blkid) const {
-    return m_dmgr.get_chunk(blkid.chunk_num())->blk_allocator()->is_blk_alloced(blkid);
+    return m_dmgr.get_chunk(blkid.chunk_num())->blk_allocator()->is_blk_alloced(blkid, true /* lock */);
 }
 
 BlkAllocStatus VirtualDev::commit_blk(BlkId const& blkid) {

diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt
@@ -110,7 +110,7 @@ if (${io_tests})
     if(${epoll_tests})
         # add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store)
         add_test(NAME MetaBlkMgr-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_meta_blk_mgr)
-        # add_test(NAME DataService-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_data_service)
+        add_test(NAME DataService-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_data_service)
 
         # add_test(NAME SoloReplDev-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_solo_repl_dev)
         # add_test(NAME HomeRaftLogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_home_raft_logstore)