Bugfix esplodeded fogi labels #488
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 21:02
A bug in the parameter label handling code was causing parameter labels to explode exponentially in size when _rebuild_paramvec was caused, leading to major memory issues. This now makes it so that the value of _paramlbls is fixed to that of the underlying operations and adds a new version of the parameter_labels property that goes through the interposer (making the interposer labels something generated on demand). Also add a threshold for coefficients printing in the LinearInterposer to avoid obnoxious labels.
Serialization wasn't working correctly for GSTGaugeOptSuite with the trivial gauge optimization argument dict. This should fix that bug.
sserita
approved these changes
Sep 19, 2024
sserita
added a commit
that referenced
this pull request
Sep 19, 2024
rileyjmurray
pushed a commit
that referenced
this pull request
Sep 24, 2024
rileyjmurray
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs. The first was reported here: #486, and was related to the parameter label management when using parameter interposers. Previously the behavior in the
OpModelmethod_rebuild_paramvecresulted in the model's parameter label vector being set to the output of_ops_paramlbls_to_model_paramlbls. What would happen though is that on subsequent calls to_rebuild_paramvecthat same output would get passed through the same method (growing larger in size each time) until the size of the labels exploded and memory ran out. The changes the behavior of the parameter label management and makes it so that the value of the internal_paramlblsvector is always that of the operations (modulo any parameter collection). When querying the value of theparameter_labelsproperty forOpModelwe now call_ops_paramlbls_to_model_paramlblson the fly and return that value, so to the end-user they should see the same thing they are used to (but there may still be edge cases).Unrelated to that bug, in the same context where the bug above arose I ran into another related to json serializing
GSTGaugeOptSuiteobjects when the 'none' gauge optimization suite option was used, which should be fixed with this patch.