New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed lab82.j2, improved lab82.yaml #9

Open

SomeCleverUsername wants to merge 1 commit into sandervanvugt:master from SomeCleverUsername:fixed-lab-8-2

SomeCleverUsername commented May 30, 2022

Hi,

I suggest the following improvements:

edited lab82.j2, as it contained no vsftpd.conf content
added tasks to install and start/enable firewalld, to be sure that dependent tasks do not fail
enclosed vars passed to template task in quotes (ln. 33-36), as ansible seems to expand the "yes" to a "true", which may produce unwanted results
added a parameter to the file module (ln. 53), so that the directory gets created, in case it should not exist for whatever reasons


          Fixed lab82.j2, improved lab82.yaml

9595cab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet