Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blob segmentation #92

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Fix blob segmentation #92

merged 4 commits into from
Jan 12, 2022

Conversation

yoda-vid
Copy link
Collaborator

Fixes #91. This PR uses the new location for the watershed function Scikit-image. I also updated tooltips for the ROI Editor options and blob scaling as mentioned in #87.

…location

Fixes #91. Change the location of `watershed` from the `morphology` to the `segmentation` package in Scikit-image now that the function was removed from the former in Scikit-image v0.19. Also, remove unused import.
Indicate which images the options change.
As indicated in #87, the "Scale detections" control label is confusing since it does not operate on the ROI Editor but only on the 3D viewer. Rename this control and add a tooltip to clarify this behavior.
@yoda-vid yoda-vid added bug Something isn't working documentation Improvements or additions to documentation labels Jan 10, 2022
@yoda-vid yoda-vid added this to the v1.6.0 milestone Jan 10, 2022
@yoda-vid yoda-vid merged commit 1012de5 into master Jan 12, 2022
@yoda-vid yoda-vid deleted the fix_blob_seg branch January 12, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob segmentation broken when using Scikit-image v0.19
1 participant