Minor improvements to theme docs #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point the theme file went to JSON but the territory examples were still in python. Also, `theme-<whatever>.json` is better.
|
shows up very ugly (see view file) due to | not being valid json |
|
Oh foof. Okay I'll update.
…On Fri, Sep 27, 2024, 10:39 AM Sander Land ***@***.***> wrote:
shows up very ugly (see view file) due to | not being valid json
—
Reply to this email directly, view it on GitHub
<#713 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACULE223QZGFTDQY6YCBVQTZYVU3VAVCNFSM6AAAAABO5XYMOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGQZTQNBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The comments and examples are useful but not valid json - it's okay to just not use syntax highlighting I think.
|
@sanderland There you go - the syntax highlighting is just not necessary for the exampled, commented snippet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the theme file went to JSON but the territory examples were still in python. Also,
theme-<whatever>.jsonis better.