Skip to content

for esp32 chips with version V3 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sheimy
Copy link

@Sheimy Sheimy commented Sep 7, 2022

for esp32 chips with version V3 you need to change
Update ESP32SJA1000.cpp

writeRegister(REG_IER, 0xef); // enable all interrupts
like this

for esp32 chips with version V3 you need to change 
  writeRegister(REG_IER, 0xef); // enable all interrupts
like this
@aldoir
Copy link

aldoir commented Sep 14, 2022

I've tested this with both V3 and older boards and they work with the suggested register configuration. Safe to merge

@jLynx
Copy link

jLynx commented Apr 7, 2023

Works for me too. Why isn't this merged in @sandeepmistry ?

@zalexzperez
Copy link

Here's the commit by Kenji Takahashi on mister0wl's forked version of the library: 232562c

It has:
modifyRegister(REG_IER, 0xef, 0xef); // enable all interrupts
instead of
writeRegister(REG_IER, 0xef); // enable all interrupts

Does anybody know which one is right/why they're different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants