Merit Committee Onboarding #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxpinheiro
commented
Nov 1, 2023
| </p> | ||
| ); | ||
|
|
||
| const idempotentArray = (length: number): number[] => | ||
| Array.apply(null, Array(length)).map((_, idx) => idx); | ||
| Array.apply(null, Array(length)).map((_, idx) => idx + 1); |
There was a problem hiding this comment.
shifting index so that RoleSetup is not the first step
maxpinheiro
commented
Nov 1, 2023
| <div | ||
| className={clsx([ | ||
| 'relative w-full min-h-[40px]', | ||
| absoluteDropdown && 'z-[2]', |
There was a problem hiding this comment.
ensures that absolute dropdowns are above info icons
maxpinheiro
commented
Nov 1, 2023
| @@ -59,6 +59,7 @@ | |||
| top: 150%; | |||
| left: 50%; | |||
| margin-left: -70px; | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
fixes bug where tooltip appears when hovering on hidden tooltip text (since we set opacity and not visibility, tooltip text is still hoverable when hidden)
|
This PR implements an onboarding flow for non-faculty members. In the future to add onboarding support for non-faculty users, re-open this PR and make appropriate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
Description
Creates a separate onboarding for for non-faculty members that does not have the additional step for specifying ProfessorInfo.
Things you especially want reviewed
Confirm with designers that we only want two steps for faculty onboarding.
Also are we fine creating a mock ProfessorInfo for merit committee members (
createMeritInfo)? Or would we rather just create a User and no ProfessorInfo.Screenshots if Applicable
Role Setup:
Non-Faculty Screen:
Faculty Screens:
Checklist