Martin/first pass #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mganahl
commented
Jan 9, 2025
jax_ib/base/time_stepping.py
Outdated
| u[i] = tree_math.Vector(u_temp) | ||
| k[i] = explicit_terms(u[i]) | ||
|
|
||
| u_star = u0 + dt * sum(b[j] * k[j] for j in range(num_steps) if b[j])-dP # this operation somehow resets the time stamp of the boundary condition, so we need to reset it |
There was a problem hiding this comment.
why is dP not multiplied by dt here?
|
Hi @hashimmg! This is a first pass of me through the code, making some minor modifications to test my understanding and shortening/cleaning pieces of the code base. Could you take a look at let me know if this introduced any major issues? You don't need to go through all the changes, the main ones are probably in time_stepping.py and IBM_Force.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.