Merge pull request #394 from sancsoft/393-points-ui-should-not-show-e…

…dit-icon-for-users-who-cant-edit-points added a condition on points edit to make it show for any role other t…
sancsoft · Jan 13, 2025 · 69ce33d · 69ce33d
2 parents 33ca0a2 + 52b7a95
commit 69ce33d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/angular/hq/src/app/planning/planning-points/planning-points.component.html b/src/angular/hq/src/app/planning/planning-points/planning-points.component.html
@@ -82,9 +82,18 @@ <h1 class="font-rajdhani font-semibold text-3xl px-5 mb-5">Planning Points</h1>
             >
           </td>
           <td>
-            <button (click)="editStaffPlanningPoint(staff)" title="Edit points">
-              <i class="bi bi-pencil-fill text-gray-450"></i>
-            </button>
+            @if (
+              [HQRole.Manager, HQRole.Partner, HQRole.Administrator]
+                | inRole
+                | async
+            ) {
+              <button
+                (click)="editStaffPlanningPoint(staff)"
+                title="Edit points"
+              >
+                <i class="bi bi-pencil-fill text-gray-450"></i>
+              </button>
+            }
           </td>
           @for (point of staff.points; track point.id) {
             <td width="165" class="border-l border-black">

diff --git a/src/angular/hq/src/app/planning/planning-points/planning-points.component.ts b/src/angular/hq/src/app/planning/planning-points/planning-points.component.ts
@@ -26,6 +26,8 @@ import { formControlChanges } from '../../core/functions/form-control-changes';
 import { PlanningPointsModalComponent } from '../planning-points-modal/planning-points-modal.component';
 import { Dialog } from '@angular/cdk/dialog';
 import { SelectInputComponent } from '../../core/components/select-input/select-input.component';
+import { HQRole } from '../../enums/hqrole';
+import { InRolePipe } from '../../pipes/in-role.pipe';
 
 @Component({
   selector: 'hq-planning-points',
@@ -34,6 +36,7 @@ import { SelectInputComponent } from '../../core/components/select-input/select-
     CommonModule,
     CoreModule,
     RouterLink,
+    InRolePipe,
     FormsModule,
     ReactiveFormsModule,
     SelectInputComponent,
@@ -56,6 +59,8 @@ export class PlanningPointsComponent implements OnDestroy {
   chargeCodeToColor = chargeCodeToColor;
   private destroyed$: ReplaySubject<boolean> = new ReplaySubject(1);
 
+  HQRole = HQRole;
+
   summary$: Observable<GetPointsSummaryResponseV1>;
 
   constructor(