Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix member pagination on OER show pages #2407

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bkiahstroud
Copy link
Collaborator

Ref:

Pagination was attempting to act upon a local variable that didn't exist; it was removed in this commit:

Replace it with the presenter method that Hyrax typically uses to display member presenters

Expected Behavior Before Changes

Viewing the show page of an OER work that has 11+ members (e.g. FileSets) throws a 500 error

Expected Behavior After Changes

OER members display in a paginated list

Screenshots / Video

Paginated members image

@samvera/hyku-code-reviewers

Pagination was attempting to act upon a local variable that didn't
exist; it was removed in this commit:
- notch8/palni-palci@fbe9093

Replace it with the presenter method that Hyrax typically uses to
display member presenters
Copy link

github-actions bot commented Jan 11, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 12s ⏱️ -36s
2 055 tests ±0  1 996 ✅  - 3  56 💤 ±0  3 ❌ +3 
2 082 runs  ±0  2 021 ✅  - 3  58 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 3245220. ± Comparison against base commit 78d79ae.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7f0f2cf6-c3dc-4c39-a366-11ab0062a8be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 44fa26cd-0d36-41e3-ae49-24e07a424b6b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read c23b4974-1edc-4fb7-9979-197cbab1391d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update fa47cda7-eb42-4de3-ac8e-b141c4f81b8b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3ab69d0c-2650-48e7-9253-d8cd6e0ab11b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 043958c1-c906-4ff9-bb7b-9c857472656a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 57b76281-6683-4bb5-aad4-f70d4423e100
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8865ccb5-fc57-4a11-b6a8-de9b4149cf1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6dfbdd53-d0f6-4cdd-83a3-bc256559e45d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 11601103-6088-4fec-a5ab-8ade7374c0db
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 4767c670-ad4d-453d-9752-28e054212371
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 1e899fb8-6901-4ed2-9380-38e76662ac87
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cdde9a1a-7564-4bfb-bc66-6a5bee0ac808
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 9f74e4cd-41f1-4e7f-a025-611401fc9db3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy e305d9af-9ae2-4c76-b7ab-c6311df757e3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 7446ed8d-6cb3-4b95-9a36-547e7b8a139e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 14fcfef7-a379-45a9-b89a-15f83aff0262
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 6108e061-fabc-4d5b-ac52-4fbbc676d9b2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy fb1abd7a-52e6-4878-a440-d48a095defd6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d96eba22-2166-479f-8a8b-6b3de1d0cdf2
…

♻️ This comment has been updated with latest results.

@bkiahstroud bkiahstroud merged commit e07ca03 into main Jan 13, 2025
5 of 9 checks passed
@bkiahstroud bkiahstroud deleted the oers-with-many-members-throw-error-on-show-page branch January 13, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants