replace linkeddata dependency with rdf and nokogiri #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the linkeddata gem (https://github.com/ruby-rdf/linkeddata/) is an omnibus/metadistribution of large parts of the rdf_rb ecosystem, including "all parsing/serialization plugins." ldpath isn't actually using them all. By replacing dependency with only the sub-parts of `linkeddata` actually being used, we can dramatically reduce the dependency tree of anything downstream from `ldpath`, reducing install time and size for those downstream things, and eliminating unnecessary dependency tree conflicts. rdf and nokogiri appear to be the only parts of linkeddata actually used.
|
Failing tests appears unrelated to me. (Tests all pass locally for me) |
jrochkind
added a commit
to sciencehistory/scihist_digicoll
that referenced
this pull request
Jan 21, 2020
ldpath is a dependency of qa/questioning_authority (used for auto-complete from LC vocabs). The new 1.1.0 release eliminates some unneccessary unused dependencies of ldpath, making our total dependency tree in Gemfile.lock a lot smaller. samvera-labs/ldpath#20 This new Gemfile.lock was produced by simply running bundle update ldpath --conservative And checking in resulting gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the linkeddata gem (https://github.com/ruby-rdf/linkeddata/) is an omnibus/metadistribution of large parts of the rdf_rb ecosystem, including "all parsing/serialization plugins." ldpath isn't actually using them all. By replacing dependency with only the sub-parts of
linkeddataactually being used, we can dramatically reduce the dependency tree of anything downstream fromldpath, reducing install time and install size for those downstream things, and eliminating unnecessary dependency tree conflict potential.rdfandnokogiriappear to be the only dependencies oflinkeddatagem that are actually used by ldpath.Please note: I am not actually familiar with the
ldpathcode or related code, this PR is just based on mechanically trying to get tests to pass with reduced dependencies. If test coverage is poor, this might not be a reliable change? If there are other reasons not captured by tests that removing linkeddata as a dependency could be disruptive for downstream? I rely on code review from ideally someone more familiar with this ecosystem to give us confidence that this makes sense, maybe @no-reply ?Closes #19