Rails / Hyrax Upgrade #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to include the spec files in the gemfile list. And including `bin/rails` can wreck havoc on the downstream application. Related to: - samvera/hyrax#6146
|
I think it's great that y'all are working on updating this gem! I know the last attempt got a little tricky and lost steam. Seeing how you've recently made this gem a dependency of |
We were getting the error: `ActionController::RespondToMismatchError in Hyrax::ImagesController#manifest` `respond_to was called multiple times and matched with conflicting formats in this action. Please note that you may only call respond_to and match on a single format per action.` This commit fixes that by only rendering json for manifest requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a new branch to do a Hyrax upgrade since the Hyrax 3.0 upgrade branch is a bit stalled out.