Fix output label generation when input url has query string #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Looks god from what I can tell.
I see there is a weird failing test case. FWIW Rails 3.0 is EOL so it could be dropped from the build matrix along with other end of life ruby/rails versions. This could be handled in a separate PR so this one can stay focused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output label and id generation uses the input url from the technical metadata. Since this url is a string from the file, we must convert it to the URI class for Sharepoint urls to be properly sanitized and processed.