fix issue #12 -- empty (single-value) profile attributes should be ni…

…l rather than an empty string..

lib/rubydora/datastream.rb

@@ -180,9 +180,9 @@ def profile_xml_to_hash profile_xml
                    sum[node.name] ||= []
                    sum[node.name] << node.text
                    sum
-                 end
-      h.select { |key, value| value.length == 1 }.each do |key, value|
-        h[key] = value.first
+                 end.reject { |key, values| values.empty? }
+      h.select { |key, values| values.length == 1 }.each do |key, values|
+        h[key] = values.reject { |x| x.empty? }.first 
       end
 
       h['dsSize'] &&= h['dsSize'].to_i rescue h['dsSize']

lib/rubydora/digital_object.rb

@@ -125,10 +125,11 @@ def profile
                      end
 
                      sum
-                   end
-        h.select { |key, value| value.length == 1 }.each do |key, value|
+                   end.reject { |key, values| values.empty? }
+
+        h.select { |key, values| values.length == 1 }.each do |key, values|
           next if key == "objModels"
-          h[key] = value.first
+          h[key] = values.reject { |x| x.empty? }.first
         end
         @new = false
 

spec/lib/digital_object_spec.rb

@@ -33,7 +33,11 @@
       h = @object.profile
 
       expect { h['asdf'] = 'asdf' }.to raise_error
+    end
 
+    it "should return nil for empty profile fields" do
+      @mock_repository.should_receive(:object).with(:pid => 'pid').and_return("<objectProfile><a></a></objectProfile>")
+      @object.profile['a'].should be_nil
     end
   end