Convert to typescript #6
Open
+861
−724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your contribution. Another thing I wanted to do is to test bundle sizes vs plain JS. I don't expect the change to be significant, but I do want to know the difference. I'm sorry if I wasn't very clear about that, I just didn't expect a contribution that soon. And again, Thank you! |
|
Not a problem. Feel free to take it or leave it. If the changes aren't too significant, it's likely not a ton of work to incorporate them into my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelgozi , interesting in trying out your library. I noticed you were planning to convert to typescript, so I gave it a first pass here. Let me know what you think
I left some of the types I wasn't sure about as
unknownwhere possible