Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting bandwidth limits #816

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Allow setting bandwidth limits #816

merged 9 commits into from
Feb 3, 2023

Conversation

samschott
Copy link
Owner

@samschott samschott commented Jan 28, 2023

The initial version is CLI / config file only. Bandwidth limits apply separately for uploads and downloads across all parallel transfers. Bandwidth is limited by delaying transmission of chunks at a 2 kB size, i.e., bandwidth limits < 2 kB / sec will result in spiky network usage instead of smooth limiting.

Fixes #438.

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4bb5c02). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage        ?   78.26%           
=======================================
  Files           ?       42           
  Lines           ?     7445           
  Branches        ?        0           
=======================================
  Hits            ?     5827           
  Misses          ?     1618           
  Partials        ?        0           
Flag Coverage Δ
pytest 78.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samschott samschott merged commit 7c3029d into main Feb 3, 2023
@samschott samschott deleted the bandwidth-control branch February 3, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow internet connection, parallel uploads time out, entire home network unusable
1 participant