Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Server Sent Events based Querying #67

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

torbrenner
Copy link
Collaborator

This pull request replaces the default Spot implementation with the Rust Spot implementation, which queries the sites using server send envents. Additionally the deployment files are updated to deploy the Rust based spot implementation.

@torbrenner torbrenner force-pushed the feature/switchToSSE branch from a529bea to ba44577 Compare March 19, 2024 15:44
@torbrenner torbrenner changed the base branch from main to develop March 19, 2024 15:44
docker-compose.dev.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@patrickskowronekdkfz patrickskowronekdkfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good so far, however we should invest time into correct error handling

packages/lib/src/classes/spot.ts Outdated Show resolved Hide resolved
packages/lib/src/classes/spot.ts Outdated Show resolved Hide resolved
packages/lib/src/classes/spot.ts Outdated Show resolved Hide resolved
packages/lib/src/classes/spot.ts Show resolved Hide resolved
@torbrenner torbrenner requested a review from Threated March 20, 2024 08:31
@torbrenner torbrenner merged commit 3bc4167 into develop Mar 20, 2024
5 checks passed
@torbrenner torbrenner deleted the feature/switchToSSE branch March 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants