feat: Display "Processing..." for claimed sites in ResultsTableComponent #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000daysofcode
force-pushed
the
feature/results_table_claimed_sites_display_processing
branch
from
66a94c2 to
1e054ac
Compare
1000daysofcode
force-pushed
the
feature/results_table_claimed_sites_display_processing
branch
from
1e054ac to
64c9815
Compare
MatsJohansen87
approved these changes
Mar 19, 2024
MatsJohansen87
deleted the
feature/results_table_claimed_sites_display_processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Summary
This is based on a Confluence ticket with the attached mock-up:
Description
Previously, the
ResultsTableComponentdidn't display a table data row until it had the status"succeeded". The change in behavior now displays the text "Processing..." in place of data while they are"claimed"but not yet"succeeded".Related Issue
See General Summary above
Motivation and Context
How Has This Been Tested?
This was tested by running a Lens instance with Beam locally in order to ensure data displayed as expected for multiple queries.
Screenshots (if appropriate):